feat(providers): single database mode #1101
Conversation
|
@psav I've opted for "single" as the name of the db mode. Suggestions and reviews are welcome. Thank you. |
vkrizan
force-pushed
the
single-db-provider
branch
from
0f87516 to
9e4a061
Compare
vkrizan
force-pushed
the
single-db-provider
branch
2 times, most recently
from
e0a2a56 to
86ee564
Compare
vkrizan
force-pushed
the
single-db-provider
branch
from
86ee564 to
5d02dad
Compare
|
|
||
| var pgPassword string | ||
| if setAdmin { | ||
| pgPassword, err = utils.RandPassword(16, provutils.RCharSet) |
There was a problem hiding this comment.
My initial thought was to disable admin user for apps, however some apps might still require this to do some setups (i.e. create additional users). @psav any suggestions how we should approach this situation? I guess, one of the option is to update those services needing such privileges, or look at the privileges case-by-case.
There was a problem hiding this comment.
It's tricky because ephemeral usage often relies on them needing to do more stuff than usual, but in prod they will just get the credentials which are appropriate
|
I'm opening this up from a draft state for review. There still might be some small issues in certain conditions. I prefer to get this out sooner to do a bunch of testing on a test cluster. Thank you. |
Creates a new database provider mode named `single`. The aim of the mode is to create a single database instance and share it between the apps by separating them by Posgres schemas. Each app gets a schema created by the name of the requested database. Schemas are created under environment's database, with the same name as the ClowdEnv. RHINENG-14526
vkrizan
force-pushed
the
single-db-provider
branch
from
5d02dad to
b7285df
Compare
We should talk about the expectation here and I was thinking we can deploy this for testing in the cluster - without merging it and only merge when we are ready - allows us to not goof up the cluster too much. @bsquizz @wcmitchell |
Creates a new database provider mode named
single.The aim of the mode is to create a single database instance and share it
between the apps by separating them by Posgres schemas.
Each app gets a schema created by the name of the requested database.
Schemas are created under environment's database, with the same name as
the ClowdEnv.
Adds the following refactorings:
provutils.DefaultPGPortto set port constantprovutils.DefaultPGAdminUsernameto set default PG admin userprovutils.PGAdminConnectionStrthat builds sanitized connection string to PG from aDatabaseConfigusing admin credsprovutils.ReadDbConfigFromSecretto reuse read ofDatabaseConfigs from secrets, optionally using a cacheRHINENG-14526